[openib-general] MT25218 (aka Arbel memfree) support

[Michael S. Tsirkin]

Hello!
Quoting r. Hal Rosenstock (halr at voltaire.com) "Re: [openib-general] MT25218 (aka Arbel memfree) support":
> On Wed, 2004-12-15 at 08:24, Michael S. Tsirkin wrote:
> > Thats an unrelated issue.
> > 
> > With DDR hidden AFAIK the only difference is
> > that FMRs dont work since you have to use a command to access the
> > internal DDR.
> > 
> > Do you know of any issues with that?
> 
> Currently, the AV needs to be read when sending UD:
> 
> int mthca_read_ah(struct mthca_dev *dev, struct mthca_ah *ah,
>                   struct ib_ud_header *header)
>         if (ah->on_hca)
>                 return -EINVAL;
> 
> on_hca is set in mthca_create_ah when DDR is hidden
> 
> -- Hal


But 

        ah->on_hca = 0;

        if (!atomic_read(&pd->sqp_count) &&
            !(dev->mthca_flags & MTHCA_FLAG_DDR_HIDDEN)) {
                index = mthca_alloc(&dev->av_table.alloc);

                /* fall back to allocate in host memory */
                if (index == -1)
                        goto host_alloc;

                av = kmalloc(sizeof *av, GFP_KERNEL);
                if (!av)
                        goto host_alloc;

                ah->on_hca = 1;
                ah->avdma  = dev->av_table.ddr_av_base +
                        index * MTHCA_AV_SIZE;
        }


So it shouldnt be set when DDR is hidden.

mst