[openib-general] Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver

[YOSHIFUJI Hideaki / 吉藤英明]

In article <200412192215.fZX1ZQqQD4QGkKcF at topspin.com> (at Sun, 19 Dec 2004 22:15:14 -0800), Roland Dreier <roland at topspin.com> says:

> +enum {
> +	IPOIB_PACKET_SIZE         = 2048,
> +	IPOIB_BUF_SIZE 		  = IPOIB_PACKET_SIZE + IB_GRH_BYTES,
> +
> +	IPOIB_ENCAP_LEN 	  = 4,
> +
> +	IPOIB_RX_RING_SIZE 	  = 128,
> +	IPOIB_TX_RING_SIZE 	  = 64,
> +
> +	IPOIB_NUM_WC 		  = 4,
> +
> +	IPOIB_MAX_PATH_REC_QUEUE  = 3,
> +	IPOIB_MAX_MCAST_QUEUE     = 3,

above entries does not seem to appropriate for enum (than #define).


> +
> +	IPOIB_FLAG_OPER_UP 	  = 0,
> +	IPOIB_FLAG_ADMIN_UP 	  = 1,
> +	IPOIB_PKEY_ASSIGNED 	  = 2,
> +	IPOIB_PKEY_STOP 	  = 3,
> +	IPOIB_FLAG_SUBINTERFACE   = 4,
> +	IPOIB_MCAST_RUN 	  = 5,
> +	IPOIB_STOP_REAPER         = 6,

this seems ok, but are "xxx_FLAG_xxx" entries really flags?

> +	IPOIB_MAX_BACKOFF_SECONDS = 16,

ditto, w/ first one.

> +	IPOIB_MCAST_FLAG_FOUND 	  = 0,	/* used in set_multicast_list */
> +	IPOIB_MCAST_FLAG_SENDONLY = 1,
> +	IPOIB_MCAST_FLAG_BUSY 	  = 2,	/* joining or already joined */
> +	IPOIB_MCAST_FLAG_ATTACHED = 3,

seems fine, but are these really flags?

--yoshfuji