[openib-general] Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver

[YOSHIFUJI Hideaki / 吉藤英明]

In article <200412201314.35502.arnd at arndb.de> (at Mon, 20 Dec 2004 13:14:35 +0100), Arnd Bergmann <arnd at arndb.de> says:

> On Maandag 20 Dezember 2004 07:58, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> > Roland Dreier <roland at topspin.com> says:
> > 
> > > +enum {
> > > +     IPOIB_PACKET_SIZE         = 2048,
> > > +     IPOIB_BUF_SIZE            = IPOIB_PACKET_SIZE + IB_GRH_BYTES,
> > > +
> > > +     IPOIB_ENCAP_LEN           = 4,
> > > +
> > > +     IPOIB_RX_RING_SIZE        = 128,
> > > +     IPOIB_TX_RING_SIZE        = 64,
> > > +
> > 
> > above entries does not seem to appropriate for enum (than #define).
> 
> According to Documentation/CodingStyle, it actually is preferred like this.
> See also include/linux/ide.h for another example where this is done.

No, it is not the similar case.

--yoshfuji