[openib-general] [PATCH]spinlock shouldn't be held while calling ib_post_send()

Hal Rosenstock halr at voltaire.com
Mon Nov 1 07:23:33 PST 2004


On Fri, 2004-10-29 at 20:09, Sean Hefty wrote:
> On Fri, 29 Oct 2004 18:06:47 -0600
> Shirley Ma <xma at us.ibm.com> wrote:
> 
> > Here is the patch.
> 
> Note that my patch removes the lock when calling ib_post_send.  But,
> holding the lock when calling ib_post_send() should be fine.  Also, the
> current completion code assumes that the work requests are queued in the
> same order that the sends are posted in.  Releasing the lock after
> queuing the request, but before calling ib_psot_send() allows work
> requests to be posted out of order from the order that they are queued
> on the send posted list.

So should this patch be applied or is it superceeded by your pending
patch (and I should wait for that) ?

Thanks.

-- Hal




More information about the general mailing list