[openib-general] [RFC] [PATCH] Remove redundant ib_qp_cap from 2 verb routines.

Hal Rosenstock halr at voltaire.com
Mon Nov 1 08:24:35 PST 2004


On Fri, 2004-10-29 at 16:14, Sean Hefty wrote:
> On Fri, 29 Oct 2004 13:01:03 -0700 (PDT)
> Krishna Kumar <krkumar at us.ibm.com> wrote:
> 
> > Hi,
> > 
> > I know this changes the verbs interface a bit, but ...
> > 
> > I don't see a value in the qp_cap being passed to different routines,
> > when either ib_qp_attr or ib_qp_init_attr, both of which contain a
> > qp_cap, are being passed at the same time.
> 
> The parameter is there to separate input/output parameters, and resulted
> from the original VAPI evolution of the code.  There's no strong
> technical reason that it cannot be removed.

Should this patch be applied ? If so, I will test this and then it can
also be merged to roland's branch.

-- Hal




More information about the general mailing list