[openib-general] [PATCH]remove redundant assignment in ib_post_send_mad()

[Sean Hefty]

On Mon, 01 Nov 2004 18:39:59 -0500
Hal Rosenstock <halr at voltaire.com> wrote:

> I don't think this is an "or". A check for *bad_send_wr should be
> added(which might be changed based on the below question). I will post
> a patch for this. IMO these should be BUG_ON but just errors as these
> are localized coding errors in some client.
> 
> > As a minor optimization, we could make bad_send_wr
> > optional for cases where only a single work request is being posted.
> 
> If *bad_send_wr is to be validated, the only time when NULL is allowed
> is when there is only one send_wr. Wouldn't this nullify any savings
> (unless the validation is removed) ?

Yes, I was thinking of the case where we removed the validation, but the
savings is to make it easier on clients that always send a single MAD at
a time.

- Sean