[openib-general] [PATCH] Missing check for atomic_dec inib_post_send_mad

Sean Hefty sean.hefty at intel.com
Wed Nov 3 08:34:29 PST 2004


>Couple of issues with the new code (same as old code, though) :
>
>1. printk(KERN_ERR PFX "No client 0x%x for received MAD "
>                      "on port %d\n",
>		      hi_tid, port_priv->port_num);
>   and printk(KERN_NOTICE PFX "No matching mad agent found for "
>                       "received MAD on port %d\n", port_priv->port_num);
>   both get printed when mad_agent is not found in solicited case.
>
>2. spin_unlock is performed after all the printk's, which is a bit icky.
>
>Compile-tested patch (not tested) follows at the end of the mail. Let me
>know if I should fix above problems too.

Thanks for the patch.  If you can do something with the printk's, that
would be good.  They should be KERN_NOTICE, but we may want to consider
just removing them.

- Sean




More information about the general mailing list