[openib-general] [PATCH] Cleanup spaces to tabs

Krishna Kumar krkumar at us.ibm.com
Wed Nov 3 15:52:16 PST 2004


Hi Hal,

The same patch on latest bits ....

thx,

- KK

diff -ruNp 1/agent.c 2/agent.c
--- 1/agent.c	2004-11-03 15:50:04.000000000 -0800
+++ 2/agent.c	2004-11-03 15:50:47.000000000 -0800
@@ -189,7 +189,7 @@ int smi_handle_dr_smp_recv(struct ib_smp
 		if (hop_ptr == 1) {
 			if (smp->dr_slid == IB_LID_PERMISSIVE) {
 				/* giving SMP to SM - update hop_ptr */
-                                smp->hop_ptr--;
+				smp->hop_ptr--;
 				return 1;
 			}
 			/* smp->hop_ptr updated when sending */
@@ -327,7 +327,7 @@ static int agent_mad_send(struct ib_mad_
 					  PCI_DMA_TODEVICE);
 	gather_list.length = sizeof(struct ib_mad);
 	gather_list.lkey = (*port_priv->mr).lkey;
-
+
 	send_wr.next = NULL;
 	send_wr.opcode = IB_WR_SEND;
 	send_wr.sg_list = &gather_list;
@@ -335,7 +335,7 @@ static int agent_mad_send(struct ib_mad_
 	send_wr.wr.ud.remote_qpn = mad_recv_wc->wc->src_qp; /* DQPN */
 	send_wr.wr.ud.timeout_ms = 0;
 	send_wr.send_flags = IB_SEND_SIGNALED | IB_SEND_SOLICITED;
-
+
 	ah_attr.dlid = mad_recv_wc->wc->slid;
 	ah_attr.port_num = mad_agent->port_num;
 	ah_attr.src_path_bits = mad_recv_wc->wc->dlid_path_bits;
@@ -364,7 +364,7 @@ static int agent_mad_send(struct ib_mad_
 		kfree(agent_send_wr);
 		goto out;
 	}
-
+
 	send_wr.wr.ud.ah = agent_send_wr->ah;
 	if (mad->mad_hdr.mgmt_class == IB_MGMT_CLASS_PERF_MGMT) {
 		send_wr.wr.ud.pkey_index = mad_recv_wc->wc->pkey_index;
@@ -441,8 +441,8 @@ static void agent_send_handler(struct ib
 {
 	struct ib_agent_port_private	*port_priv;
 	struct ib_agent_send_wr		*agent_send_wr;
-	struct list_head                *send_wr;
-	unsigned long                   flags;
+	struct list_head		*send_wr;
+	unsigned long			flags;

 	/* Find matching MAD agent */
 	port_priv = ib_get_agent_mad(NULL, 0, mad_agent);
@@ -460,7 +460,7 @@ static void agent_send_handler(struct ib
 		       "is empty\n", (unsigned long long) mad_send_wc->wr_id);
 		return;
 	}
-
+
 	agent_send_wr = list_entry(&port_priv->send_posted_list,
 				    struct ib_agent_send_wr,
 				    send_list);
@@ -469,8 +469,8 @@ static void agent_send_handler(struct ib
 				     send_list);

 	/* Remove from posted send MAD list */
-        list_del(&agent_send_wr->send_list);
-        spin_unlock_irqrestore(&port_priv->send_list_lock, flags);
+	list_del(&agent_send_wr->send_list);
+	spin_unlock_irqrestore(&port_priv->send_list_lock, flags);

 	/* Unmap PCI */
 	pci_unmap_single(mad_agent->device->dma_device,
@@ -547,8 +547,8 @@ int ib_agent_port_open(struct ib_device
 		goto error3;
 	}

-        /* Obtain MAD agent for PerfMgmt class */
-        reg_req.mgmt_class = IB_MGMT_CLASS_PERF_MGMT;
+	/* Obtain MAD agent for PerfMgmt class */
+	reg_req.mgmt_class = IB_MGMT_CLASS_PERF_MGMT;
 	port_priv->perf_mgmt_agent = ib_register_mad_agent(device, port_num,
 							   IB_QPT_GSI,
 							   NULL, 0,
@@ -606,7 +606,7 @@ int ib_agent_port_close(struct ib_device
 	ib_unregister_mad_agent(port_priv->perf_mgmt_agent);
 	ib_unregister_mad_agent(port_priv->lr_smp_agent);
 	ib_unregister_mad_agent(port_priv->dr_smp_agent);
-        kfree(port_priv);
+	kfree(port_priv);

 	return 0;
 }
diff -ruNp 1/mad.c 2/mad.c
--- 1/mad.c	2004-11-03 15:50:04.000000000 -0800
+++ 2/mad.c	2004-11-03 15:50:50.000000000 -0800
@@ -1536,7 +1536,7 @@ static inline int ib_mad_change_qp_state
 	struct ib_qp_attr *attr;
 	int attr_mask;

-        attr =  kmalloc(sizeof *attr, GFP_KERNEL);
+	attr =  kmalloc(sizeof *attr, GFP_KERNEL);
 	if (!attr) {
 		printk(KERN_ERR PFX "Couldn't allocate memory for ib_qp_attr\n");
 		return -ENOMEM;

On Wed, 3 Nov 2004, Hal Rosenstock wrote:

> On Wed, 2004-11-03 at 13:45, Krishna Kumar wrote:
> > Entire openib cleaned up to remove 8 spaces to replace with
> > tabs, just two files though :-)
>
> Any chance I could get you to regenerate this patch with the latest code
> ? I just made a major change to both mad.c and agent.c so this doesn't
> apply too easily and I'm not sure I could manually fix it right now.
>
> Thanks in advance.
>
> -- Hal
>
>
>




More information about the general mailing list