[openib-general] [PATCH] mad: Handle outgoing SMPs in ib_post_send_mad

Roland Dreier roland at topspin.com
Fri Nov 5 21:23:13 PST 2004


    Sean> Okay.  I was just going by the coding style documentation
    Sean> that mentioned that this was a "hard limit".  If it's not
    Sean> that big of a deal, then I'll only worry about excessively
    Sean> long lines.

Yeah, if you read through the kernel source, you can find tons and
tons of lines somewhat longer than 80 characters.  In fact just now I
was noticing gems like the 125-character line

struct class_device *class_simple_device_add(struct class_simple *cs, dev_t dev, struct device *device, const char *fmt, ...)

in drivers/base/class_simple.c... maybe a better example of the right
way to do things is a line like

			if (tp->link_config.advertising & ADVERTISED_1000baseT_Half)

from drivers/net/tg3.c, which ends in column 83 but look fine.

 - R.



More information about the general mailing list