[openib-general] [PATCH] Unnecessary initialization of sa_query in failure case.

root root at DYN318430BLD.linux.local
Tue Nov 9 13:32:15 PST 2004


diff -ruNp org/core/sa_query.c new/core/sa_query.c
--- org/core/sa_query.c	2004-11-09 12:51:35.000000000 -0800
+++ new/core/sa_query.c	2004-11-09 13:30:38.000000000 -0800
@@ -547,7 +547,6 @@ int ib_sa_path_rec_get(struct ib_device
 	*sa_query = &query->sa_query;
 	ret = send_mad(&query->sa_query, timeout_ms);
 	if (ret) {
-		*sa_query = NULL;
 		kfree(query->sa_query.mad);
 		kfree(query);
 	}
@@ -623,7 +622,6 @@ int ib_sa_mcmember_rec_query(struct ib_d
 	*sa_query = &query->sa_query;
 	ret = send_mad(&query->sa_query, timeout_ms);
 	if (ret) {
-		*sa_query = NULL;
 		kfree(query->sa_query.mad);
 		kfree(query);
 	}




More information about the general mailing list