[openib-general] [PATCH] agent: Fix agent_mad_send PCI mapping and gather address and length

[Roland Dreier]

>>>>> "Hal" == Hal Rosenstock <halr at voltaire.com> writes:

    Hal> I can see now that this is wrong and have a fix for what
    Hal> stops IPoIB from working. The problem was that the response
    Hal> was received by the MAD layer but not dispatched due to the
    Hal> change(s) noted above.

    Hal> So I am patching at least enough to get things operational
    Hal> for now.  Please confirm that it works for you. I will not
    Hal> touch things until I hear that it does.

Yes, IPoIB works for me again.

    Hal> Also, it seems to me that no response needs to be handed to
    Hal> process_mad.  Does this optimization make sense ?

I'm not sure I understand the question.  process_mad definitely needs
a buffer to return a response in.  Are you suggesting that process_mad
overwrite the input buffer when it generates a response?  That's
probably OK although I'm not sure if it's much of an improvement
(process_mad will probably have to allocate a response buffer
internally and copy the response when returning).

 - R.