[openib-general] Question on handle_outgoing_smp

[Hal Rosenstock]

root wrote:
> In following code :
>
> if (smi_check_local_dr_smp(smp, mad_agent->device,
> mad_agent->port_num)) { ...
> ret = mad_agent->device->process_mad(
>                                         mad_agent->device,
>                                         0,
>                                         mad_agent->port_num,
>                                         smp->dr_slid, /* ? */
>                                         (struct ib_mad *)smp,
>                                         (struct ib_mad
> *)&mad_priv->mad);
>
> How do we guarantee that the process_mad() was supplied (not NULL) ?
> That is if smi_check_local_smp didn't get called via
> smi_check_local_dr_smp ?

Sorry for the use of a bad mail client here but I didn't receive this on my
normal
email client.

A check for process_mad routine being supplied needs to be added to this
here.
I missed it here (but had it in the other place in mad.c where process_mad
is called).
I will issue a patch for this in a while.

Thanks.

-- Hal