[openib-general] [PATCH] Enable inet6 on ib interface

[Nitin Hande]

All,

Thanks for your comments,

Roland Dreier wrote:
>     Nitin> I would appreciate if someone can review my patch to enable
>     Nitin> inet6 address on ib interface. This is the first cut, will
>     Nitin> like to hear from all. I plan to setup a bugzilla account
>     Nitin> and append this patch to the bug that Tom has created for
>     Nitin> inet6.
> 
> This looks right to me.  My only questions are:
> 
> +		eui[0] ^= 2;
> 
> I remember some discussion about whether IBTA GUIDs are already
> modified EUI-64 or not.  Is this the correct transformation or should
> we be doing something like "eui[0] |= 2;" (ie assume the universal bit
> should always be set in our IPv6 address)?  What does S10 do here?
Yes, I see S10 setting the bit as eur[0] |= 2. I will update that in my
patch.

> 
> Do we need to add an ipv6_ib_mc_map() function and call it in ndisc.c?
yes, I will code that function and send a new patch including the
comments received so far...

> 
> Also, does the IPoIB driver need any modification to use IPv6
> multicast groups correctly?
> 
> Obviously IPv6 is working for you -- are ND packets being sent to the
> IPv4 broadcast group?
Yes.

> 
> If it's OK with you, I'll check in this patch as linux-2.6.9-ipoib-ipv6.diff.
Let me update the patch and if it looks okay, you can then go ahead.
Hope that is fine....

Thanks
Nitin

> 
> Thanks,
>   Roland
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general