[openib-general] MAD handling

Hal Rosenstock halr at voltaire.com
Tue Nov 16 08:11:20 PST 2004


On Mon, 2004-11-15 at 00:25, Roland Dreier wrote:
> A few questions about MAD handling:

I'm reresponding with more concrete/specific answers to the below.

> - It looks as if the case of response DR SMPs going to the SM is not
>   handled in smi.c.  smi_check_forward_dr_smp() doesn't handle the
>   case of hop_ptr == 0, and smi_handle_dr_smp_send() just says
> 
> 		/* C14-13:4 -- hop_ptr = 0 -> should have gone to SM. */
> 
>   and returns 0, which will lead to the packet being dropped.  How
>   should this be fixed?

I added the check for hop_ptr 0 into smi_handle_dr_smp_send.
smi_check_forward_smp is correct as for hop_ptr 0 it returns 0 which
means SMP should be completed up the stack (which wasn't being done in
mad.c).

-- Hal




More information about the general mailing list