[openib-general] Re: [PATCH] ib_mad.h: Add in IB management class definitions

[Hal Rosenstock]

On Tue, 2004-08-31 at 17:59, Sean Hefty wrote:
> On Tue, 31 Aug 2004 17:39:37 -0400
> some nit-picky comments below...
>  
> > +/* Management classes */
> > +#define IB_MGMT_CLASS_PERF                     0x04
> > +#define IB_MGMT_CLASS_BM                       0x05
> > +#define IB_MGMT_CLASS_DEV_MGT                  0x06
> > +#define IB_MGMT_CLASS_COM_MGT                  0x07
> 
> I've gone back and forth on the names here.  The names closest to the spec 
> would be what you have: PERF, BM, DEV_MGT, and COM_MGT.  

Yes, the names were chosen based on the descriptions in the table on
management class methods in chapter 13 of the spec.

> For API consistency, we use MGMT, 
> instead of MGT, and DEVICE instead of DEV.  

OK.

> And I'm guessing that the resulting CM API will 
> use "cm" or "conn" in its name.  

I also think it would likely use CM.

> Anyway, I'm inclined to go with: 
> PERF_MGMT (or PM), BM, DEVICE_MGMT (or DM), and CM.  Does anyone care or have an opinion?

Fine with me.

-- Hal