[Fwd: Re: [openib-general] ib_verbs.h ib_device_attr device type]

[Sean Hefty]

On Wed, 01 Sep 2004 10:27:40 -0700
Roland Dreier <roland at topspin.com> wrote:

>     Hal> I think this has now come full circle as that was my original
>     Hal> proposal for this (to add another field to
>     Hal> ib_device_attr). Roland then responded to add it into the
>     Hal> ib_device flags. I don't really have a strong preference for
>     Hal> which way.

I'm just slow...
 
> I don't have a strong preference either.  However I would put the
> field in struct ib_device rather than ib_device_attr -- no point
> forcing the consumer to allocate a ib_device_attr and call the query
> function just to find out something that can't ever change.

I'd vote for a new field in ib_device that matches the NodeType values.  I think this should allow for a fairly easy transition in Roland's stack as well.