[openib-general] [PATCH] optional functions, ib_mad update

[Sean Hefty]

On Wed, 1 Sep 2004 15:13:37 -0700
Grant Grundler <iod00d at hp.com> wrote:

> Nit: in general, combining patches is a nono.
> (And yes, I'm guilty of that too)

Yes, and I'm aware that I've combined several patches lately.  Sorry, I'll try to stop.
 
> > -static inline int ib_modify_device(struct ib_device *device,
> > -				   int device_modify_mask,
> > -				   struct ib_device_modify *device_modify)
> > -{
> > -	return device->modify_device(device, device_modify_mask,
> > -				     device_modify);
> > -}
> 
> Why not leave this as an inline function?
>
> Or does anyone expect this to get more complicated?

I thought it might be more complicated as additional checks were added, but can switch it (and similarly formatted calls) back to inline for now, then move them later, if needed.

Thanks for the feedback!