[openib-general] [PATCH] for discussion - combine ib_send_mad_wr with ib_send_wr

[Sean Hefty]

On Thu, 02 Sep 2004 15:31:41 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> On Thu, 2004-09-02 at 13:48, Sean Hefty wrote:
> > On Thu, 02 Sep 2004 11:22:29 -0700
> > Roland Dreier <roland at topspin.com> wrote:
> > 
> > >     Sean> I think that you'll need to know if the GRH is being sent in
> > >     Sean> order to do RMPP correctly.
> > > 
> > > I don't see why... can you expand on this point?
> > 
> > I was remembering from the SF stack where it was provided on sends, but it looks like that was only done in cases where the access layer would create the address handle for the user.  So, it doesn't look like that flag is needed for sends, but only on receive completions.
> > 
> > Thanks for catching this.
> 
> Assuming the change as proposed will not be done:
> 
> Will ib_mad_flags be going away based on the above ?

In my working copy, I set ib_send_flags back as they were, and added ib_mad_flags back for use with ib_mad_recv_wc.  I have another TODO to check on zero-copy RMPP receives, so ib_mad_recv_wc (and/or ib_recv_wc) could change slightly in the future.
 
> Also, will the MAD and normal send WCs be made more similar as proposed

This requires a very minor change to the send WC (swapping two fields), so I think it makes sense to do this.