[openib-general] [PATCH] beginnings of SMI

Johannes Erdfelt johannes at erdfelt.com
Tue Sep 14 15:42:03 PDT 2004


On Tue, Sep 14, 2004, Sean Hefty <mshefty at ichips.intel.com> wrote:
> On Tue, 14 Sep 2004 15:26:14 -0700
> Johannes Erdfelt <johannes at erdfelt.com> wrote:
> 
> > On Tue, Sep 14, 2004, Sean Hefty <mshefty at ichips.intel.com> wrote:
> > > +				printk(KERN_NOTICE,
> > > +					"Need to handle DR Mad on switch");
> > [snip]
> > > +				printk(KERN_NOTICE,
> > > +					"Need to handle DR Mad on switch");
> > [snip]
> > > +		printk(KERN_ERR, "Unhandled Outgoing DR MAD case.");
> > [more snipped]
> > 
> > The comma between the logging level (KERN_NOTICE, KERN_ERR, etc) and the
> > text should not be there.
> 
> Thanks for catching this.  Obviously I hadn't added this to the build yet,
> since it can't do anything useful yet.  I'll update patch and resubmit.

Oh, and don't forget the \n (newline) :)

JE




More information about the general mailing list