[openib-general] [PATCH] SMI update
Hal Rosenstock
halr at voltaire.com
Thu Sep 16 19:49:51 PDT 2004
On Thu, 2004-09-16 at 22:14, Sean Hefty wrote:
> I'd appreciate comments from anyone,
> but particularly someone who's worked on SMI code before,
> to make sure that I'm not completely off here.
Just one comment on the ib_mad changes:
You half got in the change we have been discussing:
ib_mad.h didn't change the definition of struct ib_mad_recv_wc but
ib_mad.c had the following change:
@@ -372,7 +372,7 @@
* Walk receive buffer list associated with this WC
* No need to remove them from list of receive buffers
*/
- list_for_each_entry(entry, &mad_recv_wc->recv_buf->list, list) {
+ list_for_each_entry(entry, &mad_recv_wc->recv_buf.list, list) {
/* Free previous receive buffer */
kmem_cache_free(ib_mad_cache, buffer);
buffer = (void *)entry - sizeof(struct
ib_mad_private_header);
I will review the SMI code as I have time over the next few days.
-- Hal
More information about the general
mailing list