[openib-general] [PATCH] core_cache.c: Eliminate use of ts_kernel_[services trace].h

Roland Dreier roland at topspin.com
Fri Sep 17 17:44:57 PDT 2004


Thanks, however I haven't been cleaning things up this way because
changes like this:

    > -	TS_TRACE(MOD_KERNEL_IB, T_VERY_VERBOSE, TRACE_KERNEL_IB_GEN,
    > -		 "Updating cached port info for %s port %d",
    > +	printk(KERN_DEBUG
    > +       		"Updating cached port info for %s port %d",

mean that we spew debugging output without any way of turning it off.

Also I'm not sure whether the core_cache.c code has a future in the
real OpenIB access layer anyway so I don't know if it's worth cleaning
it up.

You can look at what I did in my ipoib directory to see how I made the
debugging output be controllable at both compile- and run-time.

 - R.



More information about the general mailing list