[openib-general] [PATCH] change SMI/GSI QP types to match QP index values

Michael S. Tsirkin mst at mellanox.co.il
Sat Sep 25 14:12:45 PDT 2004


Quoting r. Sean Hefty (mshefty at ichips.intel.com) "Re: [openib-general] [PATCH] change SMI/GSI QP types to match QP index values":
> On Fri, 24 Sep 2004 10:38:03 -0700
> Sean Hefty <mshefty at ichips.intel.com> wrote:
> 
> > 
> > Index: include/ib_verbs.h
> > ===================================================================
> > --- include/ib_verbs.h	(revision 880)
> > +++ include/ib_verbs.h	(working copy)
> > @@ -320,11 +320,11 @@
> >  };
> >  
> >  enum ib_qp_type {
> > +	IB_QPT_SMI,	/* SMI type = QP index 0 */
> > +	IB_QPT_GSI,	/* GSI type = QP index 1 */
> 
> I've committed this change.
> _______________________________________________

I think you really want:

enum ib_qp_type {
	IB_QPT_SMI=0,
	IB_QPT_GSI=1


		
to stress the fact that you really want to assign specific
values to IB_QPT_SMI/IB_QPT_GSI or the code would not work correctly.

MST



More information about the general mailing list