[openib-general] Re: [openib-commits] r2195 - in gen2/trunk/src/linux-kernel/infiniband: core include

Tom Duffy tduffy at sun.com
Wed Apr 20 13:29:06 PDT 2005


On Wed, 2005-04-20 at 13:24 -0700, Roland Dreier wrote:
> Looks like a real bug -- I think
> 
> 		flow_class = be32_to_cpu(&grh->version_tclass_flow);
> 
> should be
> 
> 		flow_class = be32_to_cpu(grh->version_tclass_flow);
> 
> (ie no "&" -- we want to swap the value, not the address!)

That is what I thought as well, but there are other places in the code
that do the same thing.

agent.c:159
ping.c:137

-tduffy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050420/f4113cb9/attachment.sig>


More information about the general mailing list