[openib-general] [PATCH][DAPL] Fix sparse warnings on dapl bu ilds

[Itamar Rabenstein]

Thanks for the patch.
Did you run kdapltest or only compiled  the code ?
kdapltest -T Q and kdapltest -T T with 1 ep should work now.
if you need help with the test let me know.

Some general notes:

1)
> Index: gen2/users/jlentini/linux-kernel/dat-provider/dapl_openib_cm.c
> ===================================================================
> --- 
   
    <<  snip >>

> @@ -799,22 +799,6 @@ DAT_RETURN dapl_ib_accept_connection(DAT
>  	return DAT_SUCCESS;
>  }
>  
> -DAT_RETURN dapl_ib_comm_established(DAPL_EP * ep_ptr)
> -{
> -	int status;
> -	DAT_RETURN dat_status = DAT_SUCCESS;
> -
> -	status = ib_send_cm_rtu(ep_ptr->cm_handle, NULL, 0);
> -	if (status) {
> -		dapl_dbg_log(DAPL_DBG_TYPE_ERR,
> -			     " dapl_ib_comm_established: 
> ib_send_cm_rtu failed: %d cm_handle: %x\n",
> -			     status, ep_ptr->cm_handle);
> -		return DAT_ERROR(DAT_INSUFFICIENT_RESOURCES, 0);
> -	}
> -
> -	return dat_status;
> -}
> -
>  /*
>   * ib_cm_get_remote_gid 
>   */

This function is currently not in use but I think we will need if we want to
support 
merging dto evds with communication  evds.

2)
 
> Index: gen2/users/jlentini/linux-kernel/dat/consumer.c
> ===================================================================
> -DAT_RETURN dat_evd_kquery(DAT_EVD_HANDLE evd_handle,
> -			  DAT_EVD_PARAM_MASK evd_param_mask,
> -			  DAT_EVD_PARAM * evd_param)
> -{
> -	if (evd_handle == NULL) {
> -		return DAT_ERROR(DAT_INVALID_HANDLE,
> -				 DAT_INVALID_HANDLE_EVD_REQUEST);
> -	}
> -	return DAT_EVD_QUERY(evd_handle, evd_param_mask, evd_param);
> -}
> -
why did you delete this function ?
Maybe there is a bug with this function but this is a real function in the
API.
I think that the bug is a mix between dat_evd_kquery and dat_evd_query.
I will look on it later


 -Itamar