[openib-general] [PATCH updated] sdp: cancel read with no iocb

Michael S. Tsirkin mst at mellanox.co.il
Mon Aug 1 06:14:45 PDT 2005


Quoting r. Michael S. Tsirkin <mst at mellanox.co.il>:
> Subject: sdp: cancel read with no iocb
> 
> Libor, I'm seeing these messages:
> 
> ib_sdp WARN: Cancel read with no IOCB. <2:0:00000005>
> 
> It seems that this warning is printed in a legal state where
> a deferred iocb is canceled. Shouldnt this sdp_warn be replaced
> with sdp_dbg_ctrl?

Ugh, that patch broke compilation with debug on.
Here's a better one.

---

Remove sdp_warn for a legal condition.

Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

Index: linux-2.6.12.2/drivers/infiniband/ulp/sdp/sdp_recv.c
===================================================================
--- linux-2.6.12.2.orig/drivers/infiniband/ulp/sdp/sdp_recv.c
+++ linux-2.6.12.2/drivers/infiniband/ulp/sdp/sdp_recv.c
@@ -942,8 +942,8 @@ static int sdp_inet_read_cancel(struct k
 	 * no IOCB found. The cancel is probably in a race with a completion.
 	 * Assume the IOCB will be completed, return appropriate value.
 	 */
-	sdp_warn("Cancel read with no IOCB. <%d:%d:%08lx>",
-		 req->ki_users, req->ki_key, req->ki_flags);
+	sdp_dbg_ctrl(NULL, "Cancel read with no IOCB. <%d:%d:%08lx>",
+		     req->ki_users, req->ki_key, req->ki_flags);
 
 	result = -EAGAIN;
 	
-- 
MST



More information about the general mailing list