[openib-general] kdapl build error on ia64

[James Lentini]

On Mon, 1 Aug 2005, Tom Duffy wrote:

> On Fri, 2005-07-29 at 16:46 -0500, John Partridge wrote:
>> I searched the archives and don't see a solution, but I think I've tracked it down
>> to a bug in ulp/kdapl/ib/dapl_util.h
>>
>> root on mig133  > diff -ruN dapl_util.h dapl_util.h-johnip
>
> Please use diff -ruNp.  See FAQ question 10.
>
>> =============== diff ===============================
>>
>> 	--- dapl_util.h 2005-07-29 16:36:17.514669886 -0500
>> 	+++ dapl_util.h-johnip  2005-07-29 16:37:11.514578548 -0500
>> 	@@ -71,7 +71,7 @@
>>
>> 	 #ifdef __ia64__
>>
>> 	-       current_value = ia64_cmpxchg("acq", v, match_value, new_value, 4);
>> 	+       current_value = ia64_cmpxchg(acq, v, match_value, new_value, 4);
>>
>>   	#elif defined (__PPC__)
>
> Please kill dapl_os_atomic_assign().  Just use cmpxchg() directly
> instead.

That sounds like a good idea. Any issues with this John?