[openib-general] [PATCH 1/2] kDAPL: remove inline functions

Or Gerlitz ogerlitz at voltaire.com
Thu Aug 4 07:13:46 PDT 2005


Tom,

Wouldn't it be simple to come with a patch that applies only to the
"dat" code ie 
(gen2/trunk/src/linux-kernel/infiniband/ulp/kdapl/kdapl.h and/or api.c)
which does 
not require --any-- code change at the cosumer side? 

that is, with the patch you sent, a call to dat_pz_create at in consumer
code was changed 

from
	-    ret = dat_pz_create (ia, &pz);
to
	+   ret = ia->common.provider->pz_create (ia, &pz);

so cant it be done with dat_pz_create being a function (or define)
calling to 

	    ia->common.provider->pz_create(ia, &pz);

similar to what is done by ib_core / libibverbs calling ib_mthca /
libmthca 

This makes the consumer code simpler and no changes are need in current
consumers

Or.



More information about the general mailing list