[openib-general] [RFC] IPoIB sockaddr_ll changes
Hal Rosenstock
halr at voltaire.com
Fri Aug 5 10:12:26 PDT 2005
On Fri, 2005-08-05 at 13:06, Tom Duffy wrote:
> On 05 Aug 2005 11:42:17 -0400, Hal Rosenstock <halr at voltaire.com> wrote:
> > I would like to get comments on this prior to sending this over to
> > kernel land.
>
> > --- net/packet/af_packet.c.orig 2005-06-29 19:00:53.000000000 -0400
> > +++ net/packet/af_packet.c 2005-08-05 11:23:24.000000000 -0400
> > @@ -140,7 +140,7 @@ dev->hard_header == NULL (ll header is a
> > mac.raw -> data
> > data -> data
> >
> > - We should set nh.raw on output to correct posistion,
> > + We should set nh.raw on output to correct position,
> > packet classifier depends on it.
> > */
> >
> > @@ -315,7 +315,7 @@ static int packet_sendmsg_spkt(struct ki
> > struct net_device *dev;
> > unsigned short proto=0;
> > int err;
> > -
> > +
> > /*
> > * Get and verify the address.
> > */
>
> Both of these are whitespace changes that shouldn't be sent with this patch.
The latter is but is removing the whitespace. Should that not be done ?
The former is a commentary typo.
-- Hal
More information about the general
mailing list