[openib-general] RE: [PATCH ] osmtest general cleanups

[Hal Rosenstock]

Hi Liran,

On Sun, 2005-08-07 at 11:28, Liran Sorani wrote:
> Hi , Hal.
> I've a few minor fixes (several white space glitches) , pls take the
> attached file , instead of the previous  ,

Thanks. Applied with some minor modifications and caveats below.

In the future can your patches be submitted as text rather than
attachments ? That is the norm for doing this.

Some comments below.

> thanks  Liran.
> 
> -----Original Message-----
> From: Liran Sorani 
> Sent: Sunday, August 07, 2005 5:57 PM
> To: 'halr at voltaire.com'
> Cc: 'openib-general at openib.org'; Amit Krig
> Subject: [PATCH ] osmtest general cleanups
> 
> 
> Hi , Hal.
> The attached patch should be applied to osmtest repository.
> It contain several cleanups (on most of the files)   :

It is easier if there is a patch per idea rather than an amalgam.

> -Removal of inform info flow .
> -Unique error messages

There are some non real error message numbers (neither hex nor decimal)
in osmt_multicast.c. Also, osmtest.c and osmt_service.c still have
duplicates.

> -Makefile.am update for compilation (required osm_helper object)

osm_helper is part of the libopensm since r2973 so this part of the
patch was not applied. Please update your osm directory.

> -Remove vendor dependencies.

Remove some OSM_VENDOR_INTF_MTL vendor dependencies
(There are still some in osmt_slvl_vl_arb.c).

> The inform info flow should be carefully ported since it requires
> direct access to ib_umad (possibly ib_verbs too) .

umad would be a temporary measure. 

Why would ib_uverbs direct access be needed ?

>  I'll send another patch for it next week .

Thanks.

-- Hal