[openib-general] Re: [PATCH] osm: add a main auto tools project for osm

Hal Rosenstock halr at voltaire.com
Sun Aug 14 05:23:23 PDT 2005


Hi Eitan,

On Sun, 2005-08-14 at 06:50, Eitan Zahavi wrote:
> Hi Hal
> 
> Fixing the patch I have sent last week by moving the bin and lib into 
> the /usr/local and keep the
> includes in place: /usr/local/include/infiniband
> 
> This patch includes:
> 1. Added a top level autotools project for OpenSM.
>    So now you need autogen.sh && configure && make && make install just 
> once for osm
>   (previously needed 4: complib, libvendor, opensm, osmtest).
> 2. Cleanup the direct override of libdir, bindir. Support --prefix
> 3.  Move osm lib, bin into default prefix (/usr/local)
> 4. Support debug build for OpenSM using --enable-debug
>    This is important to allow for asserts during runtime and various 
> other additional debug features.
>    Since the generated compilb can not be used with the release version 
> we also use a special header file that stores the type of build
>    for applications that wish to link with it.
> 5. Cleanup stale use of  AC_CHECK_LIB with no parameters
> 
> I tested the patch on :
> 2.6.12.3-smp SuSE Linux 9.3 (i586)

A couple of things:

The patch appears to be whitespace wrapped.
patching file include/configure.in
patch: **** malformed patch at line 11: depend on?

Also for debug, should -O0 be removed as Michael suggests ?

Also, why are files without changes included in the patch ? 

Thanks.

-- Hal




More information about the general mailing list