[openib-general] Re: [PATCH] osm: add a main auto tools project for osm

[Hal Rosenstock]

Hi Eitan,

On Mon, 2005-08-15 at 10:23, Eitan Zahavi wrote:
> I'm now using xemacs as my mail client. This is pure unix and
> tested to work.

That's better.

> This patch includes:
> 1. Added a top level autotools project for OpenSM.
>   So now you need autogen.sh && configure && make && make install just 
> once for osm
>  (previously needed 4: complib, libvendor, opensm, osmtest).
> 2. Cleanup the direct override of libdir, bindir. Support --prefix
> 3.  Move osm lib, bin into default prefix (/usr/local)
> 4. Support debug build for OpenSM using --enable-debug
>   This is important to allow for asserts during runtime and various 
> other additional debug features.
>   Since the generated compilb can not be used with the release version 
> we also use a special header file that stores the type of build
>   for applications that wish to link with it.
> 5. Cleanup stale use of  AC_CHECK_LIB with no parameters
> 6. Resolved another bug:  iba/ib_types.h not installed correctly

Thanks. Applied with the following minor modifications:

Min autoconf version is 2.57 rather than 2.59
Min automake version is 1.6.3 rather than 1.9.3

Also, the builds now show:
-g -O2 -g -O2 (when not configured with --enable-debug)
and
-g -O0 -D_DEBUG_ -g -O2 (when configured with --enable-debug)

Not sure which -O option gcc takes in that case. Can you remove this
duplication ?

> Signed-off-by:  Eitan Zahavi eitan at mellanox.co.il

The email address should have braces around it in the signed off line:
Signed-off-by: Eitan Zahavi <eitan at mellanox.co.il>

-- Hal