[openib-general] [PATCH][iWARP] Added provider CM verbs and queryprovider methods

[Tom Tucker]

Good question. 

It was placed in here to allow ULPs to filter 
the device notifications by the transport type. The IPoIB 
ULP, for example, doesn't care about iWARP devices. 

This method is butt simple, however, doesn't scale very well 
if you add additional transports. The alternative is to
add a 'filter' mask that allows ULPs to register for 
device type events it is interested in. I am happy to do it
either way.

What do you think?


> -----Original Message-----
> From: Sean Hefty [mailto:sean.hefty at intel.com] 
> Sent: Wednesday, August 24, 2005 6:37 PM
> To: Tom Tucker; openib-general at openib.org
> Subject: RE: [openib-general] [PATCH][iWARP] Added provider 
> CM verbs and queryprovider methods 
> 
> >@@ -59,7 +60,8 @@
> > enum ib_node_type {
> > 	IB_NODE_CA 	= 1,
> > 	IB_NODE_SWITCH,
> >-	IB_NODE_ROUTER
> >+	IB_NODE_ROUTER,
> >+	IB_NODE_IWARP
> > };
> 
> I guess I'm not sure what an iWarp node is or how it would be used.
> 
> >+/* Connection events. */
> >+enum ib_xcm_event_type {
> >+	IB_EVENT_ACTIVE_CONNECT_RESULTS,
> >+	IB_EVENT_CONNECT_REQUEST
> >+};
> >+
> >+/* iwarp connection attributes. */
> >+struct ib_connect_attr {
> >+	struct in_addr	 	local_addr;
> >+	struct in_addr	 	remote_addr;
> >+	u16 			local_port;
> >+	u16 			remote_port;
> >+};
> >+struct ib_conn_results {
> >+	int			errno;
> >+	struct ib_connect_attr  conn_attr;
> >+	int 			priv_len;
> >+        u8			private_data[0];
> >+};
> >+
> >+struct ib_conn_request {
> >+	int			cr_id;
> >+	struct ib_connect_attr  conn_attr;
> >+	int 			priv_len;
> >+        u8			private_data[0];
> >+};
> >+
> >+struct ib_xcm_event {
> >+	struct ib_device	*device;
> >+	union {
> >+		struct ib_conn_results 	connect_qp_results;
> >+		struct ib_conn_request 	connect_request;
> >+	} element;
> >+	enum ib_xcm_event_type	event;
> >+};
> >+
> 
> Why include the connection protocol as part of the verbs 
> layer?  Granted I
> haven't looked at the iWarp specs in a long time, but I don't remember
> connection establishment being part of the verbs.
> 
> - Sean
> 
>