[openib-general] [PATCH] osm: osm_sa_path_record bug

Yael Kalka eitan at mtl001.openib.org
Thu Aug 25 01:55:37 PDT 2005


Hi Hal

__osm_pr_rcv_check_mcast_dest called from osm_sa_path_record to
check if the path record request in a request for multicast path
record has a bug in it.
In the destination lid check, the check compared host-order lid with
network order.

The following simple patch fixes this bug. 

Thanks

Yael

I tested the patch on :
2.6.11-1.1369_FC4smp Fedora Core release 4 (Stentz)

Signed-off-by:  Yael Kalka <yael at mellanox.co.il>

Index: opensm/osm_sa_path_record.c
===================================================================
--- opensm/osm_sa_path_record.c	(revision 3159)
+++ opensm/osm_sa_path_record.c	(working copy)
@@ -1423,8 +1423,8 @@ __osm_pr_rcv_check_mcast_dest(
 
   if( comp_mask & IB_PR_COMPMASK_DLID )
   {
-    if( cl_ntoh16( p_pr->dlid ) >= IB_LID_MCAST_START &&
-        cl_ntoh16( p_pr->dlid ) <= IB_LID_MCAST_END )
+    if( cl_ntoh16( p_pr->dlid ) >= IB_LID_MCAST_START_HO &&
+        cl_ntoh16( p_pr->dlid ) <= IB_LID_MCAST_END_HO )
       is_multicast = TRUE;
     else if( is_multicast )
       osm_log( p_rcv->p_log, OSM_LOG_ERROR,




More information about the general mailing list