[openib-general] RE: [PATCH][iWARP] IW CM Verbs

Grant Grundler iod00d at hp.com
Fri Aug 26 16:03:21 PDT 2005


On Fri, Aug 26, 2005 at 12:01:09PM -0700, Sean Hefty wrote:
> >Please comment, and if it looks good, I'll commit this to the
> >iWARP branch tonight.
> 
> Looks fine.  See one minor comment below.
> 
> 
> >+/* This is provided in the event generated by a remote
> >+ * connect request to a listening endpoint
> >+ */
> >+struct iw_conn_request {
> >+	int			cr_id;
> >+	struct iw_conn_attr     conn_attr;
> >+        u8			*private_data;
> >+	int 			private_data_len;
> >+};
> 
> Should cr_id be an int or something more along the lines of struct iw_cm_id *?

"unsigned int" if possible please.

thanks,
grant



More information about the general mailing list