[openib-general] Re: RMPP Message Format Errors

[Hal Rosenstock]

Hi Sean,

On Fri, 2005-08-26 at 13:54, Sean Hefty wrote:
> >The 220 byte payload length is for SA. That's mostly right but assumes
> >the last segment will be full (and accounted for by the paylen in the
> >last segment).
> 
> I believe that the 220 byte payload length is for all RMPP MADs.

Yes, you're right.

>   Only the
> common and RMPP header lengths are ignored.
> 
> 
> >Doesn't it need to account for a "partial" rather than full last segment
> >transferred data in the first segment length ?
> 
> What I couldn't easily tell from the spec is whether a partial last segment is
> included in the initial payload length or not.  I read it as: "PayloadLength
> counts all the bytes in the TransferredData field of the DATA packet format."
> In my interpretation, partial data is indicated by the PayloadLength field in
> the last segment only.  It's quite possible that my interpretation is incorrect,
> in which case the calculation in the RMPP code is off.

I'm pretty sure that the intent is that the length in the first segment
reflects the valid data (plus the header to be counted) so the last
segment doesn't count as a full length (220) unless it is full.

Patch for this shortly.

-- Hal