[openib-general] [PATCH] ipoib: device removal races

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rolandd at cisco.com>:
> Subject: Re: [openib-general] [PATCH] ipoib: device removal races
> 
> Thanks, I finally applied this and put it in my git queue for 2.6.14.
> 
> I'm still thinking about the bigger patch that adds a second work
> queue.  Having one extra work queue because of the rtnl_lock issues is
> ugly enough, and I'd really like to find a way to avoid two queues.

I thought about this some more.
I think I see even more problems, like potential deadlocks were
ipoib needs to flush the link wq, link wq waits for sa query to
time out, and that needs the default wq to run.

It seems that most of the complexity comes from the way core
uses work queues to pass events to upper layers.
And I wander: couldnt core be simplified by passing up events
directly in the interrupt context?

I think IPoIB could then use plain spinlocks for most synchronisations.

-- 
MST