[openib-general] OpenSM 1.8.0 complib initial merge nits
Hal Rosenstock
halr at voltaire.com
Wed Aug 31 07:00:59 PDT 2005
Hi Yael,
I'm in the process of merging the OpenSM 1.8.0 complib changes and found
the following nits:
There are a number of violations of the coding style in terms of
alignment.
include/complib/cl_event_wheel.h has 2 END_C_DECLS
include/complib/cl_passivelock.h
state added to _cl_plock struct (description should also be added)
There is some dead code in complib/cl_timer.c::__cl_timer_prov_destroy
/* Wait for the thread to exit. */
/*
if (tmp_gp_timer_prov->thread)
pthread_join( tmp_gp_timer_prov->thread, NULL );
tmp_gp_timer_prov->thread = 0;
*/
/* Users should have cancelled all timers by now. */
/* CL_ASSERT( cl_is_qlist_empty( &tmp_gp_timer_prov->queue ) ); */
Onto libvendor next...
-- Hal
More information about the general
mailing list