[openib-general] Re: [PATCH] hotplug support: selective removal notification

Roland Dreier rolandd at cisco.com
Wed Aug 31 11:38:23 PDT 2005


    Michael> As a way of solving this, I propose the following patch.
    Michael> The idea is that instead of setting client context
    Michael> separately with ib_set_client_data, client's add method
    Michael> will return ib_client_data object which is then kept in a
    Michael> per-device list.  Returning NULL signals that the client
    Michael> will not be interested in this device.

My first reaction was that this is a good idea.  But looking at the
patch, I'm not sure if it actually improves the existing code.  It
seems there aren't any consumers that really benefit from this, and
the MAD module actually has to invent a pointer to return.

So I'm not sure whether this is worth it right now.

(BTW, perhaps the MAD module could just return (void *) 1L instead of
kmalloc'ing something it then has to kfree)

 - R.



More information about the general mailing list