[openib-general] RE: [PATCH] [TRIVIAL] OpenSM/complib: Move assert before variable is used

[Hal Rosenstock]

On Thu, 2005-12-01 at 01:41, Yael Kalka wrote:
> Hi Hal,
> This fix isn't correct, since you are asserting on a variable not yet
> initialized.

Right. My bad. This was pointed out last night by Johannes Erdfelt.
Thanks.

-- Hal

> Yael
> 
> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Wednesday, November 30, 2005 11:04 PM
> To: Yael Kalka
> Cc: openib-general at openib.org
> Subject: [PATCH] [TRIVIAL] OpenSM/complib: Move assert before variable
> is used
> 
> 
> OpenSM/complib: Move assert before variable is used
> 
> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> 
> Index: cl_dispatcher.c
> ===================================================================
> --- cl_dispatcher.c     (revision 4257)
> +++ cl_dispatcher.c     (working copy)
> @@ -344,8 +344,8 @@ cl_disp_post(
>    cl_dispatcher_t    *p_disp;
>    cl_disp_msg_t      *p_msg;
>  
> -  p_disp = handle->p_disp;
>    CL_ASSERT( p_disp );
> +  p_disp = handle->p_disp;
>    CL_ASSERT( msg_id != CL_DISP_MSGID_NONE );
>  
>    cl_spinlock_acquire( &p_disp->lock );