[openib-general] OpenSM: search_mgrp_by_mgid questions

[Eitan Zahavi]

Hi Hal,

I thought we all agree that a full MGID compare is required.
Also we should not deal with MGRPs marked "to be deleted".
For all purposes but MGRP re-route they should not exist...

Eitan Zahavi
Design Technology Director
Mellanox Technologies LTD
Tel:+972-4-9097208
Fax:+972-4-9593245
P.O. Box 586 Yokneam 20692 ISRAEL


> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Thursday, December 01, 2005 7:20 PM
> To: Eitan Zahavi
> Cc: Yael Kalka; openib-general at openib.org
> Subject: RE: [openib-general] OpenSM: search_mgrp_by_mgid questions
> 
> Hi Eitan,
> 
> On Thu, 2005-12-01 at 10:28, Eitan Zahavi wrote:
> > Hi Hal,
> >
> > You are very right. Thanks. Can you patch it?
> 
> Sure. Any prefereance for which way should the comment be (like PR or
> MCM) ?
> 
> -- Hal
> 
> > Eitan Zahavi
> > Design Technology Director
> > Mellanox Technologies LTD
> > Tel:+972-4-9097208
> > Fax:+972-4-9593245
> > P.O. Box 586 Yokneam 20692 ISRAEL
> >
> >
> > > -----Original Message-----
> > > From: Hal Rosenstock [mailto:halr at voltaire.com]
> > > Sent: Thursday, December 01, 2005 4:53 PM
> > > To: Yael Kalka
> > > Cc: openib-general at openib.org
> > > Subject: [openib-general] OpenSM: search_mgrp_by_mgid questions
> > >
> > > Hi Yael,
> > >
> > > osm_sa_path_record.c::__search_mgrp_by_mgid has the following:
> > >
> > >   p_recvd_mgid = p_ctxt->p_mgid;
> > >   p_rcv = p_ctxt->p_rcv;
> > >
> > >   /* Why not compare the entire MGID ???? */
> > >   /* different scope can sneak in for the same MGID ? */
> > >   /* EZ: I changed it to full compare ! */
> > >   if (cl_memcmp(&p_mgrp->mcmember_rec.mgid,
> > >                 p_recvd_mgid,
> > >                 sizeof(ib_gid_t)))
> > >     return;
> > >
> > > whereas osm_sa_mcmember_record.c::__search_mgrp_by_mgid has the
> > > following:
> > >
> > >   p_recvd_mcmember_rec = p_ctxt->p_mcmember_rec;
> > >   p_rcv = p_ctxt->p_rcv;
> > >
> > >   /* ignore groups marked for deletion */
> > >   if (p_mgrp->to_be_deleted)
> > >     return;
> > >
> > >   /* compare entire MGID so different scope will not sneak in for
> > >      the same MGID */
> > >   if (cl_memcmp(&p_mgrp->mcmember_rec.mgid,
> > >                 &p_recvd_mcmember_rec->mgid,
> > >                 sizeof(ib_gid_t)))
> > >     return;
> > >
> > > Shouldn't the SA PR code also check for "to be deleted" ? It also
> > seems
> > > like the comments on the MGID comparison should also be made the
same.
> > >
> > > -- Hal
> > >
> > >
> > > _______________________________________________
> > > openib-general mailing list
> > > openib-general at openib.org
> > > http://openib.org/mailman/listinfo/openib-general
> > >
> > > To unsubscribe, please visit
> > http://openib.org/mailman/listinfo/openib-general