[openib-general] RE: [PATCH] OpenSM: SA SMInfoRecord should support GetTable as well as Get method

[Yael Kalka]

Hi Hal,
If you look at the code - currently the What is returned is a record
with the 
local SMInfo record.
The code should be fixed to return a table, or a requested SMInfo record
- 
not only of the local port.
So currently - a table is not returned, and the code isn't correct with
or
without the patch...
This issue should be added to our to-do list.
Yael 

-----Original Message-----
From: Hal Rosenstock [mailto:halr at voltaire.com]
Sent: Tuesday, December 06, 2005 4:06 PM
To: Yael Kalka
Cc: openib-general at openib.org
Subject: [PATCH] OpenSM: SA SMInfoRecord should support GetTable as well
as Get method


OpenSM: SA SMInfoRecord should support GetTable as well as Get method

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

Index: osm_sa_sminfo_record.c
===================================================================
--- osm_sa_sminfo_record.c      (revision 4323)
+++ osm_sa_sminfo_record.c      (working copy)
@@ -165,7 +165,8 @@ osm_smir_rcv_process(
 
   CL_ASSERT( p_sa_mad->attr_id == IB_MAD_ATTR_SMINFO_RECORD );
 
-  if (p_sa_mad->method != IB_MAD_METHOD_GET)
+  if ( (p_sa_mad->method != IB_MAD_METHOD_GET) &&
+       (p_sa_mad->method != IB_MAD_METHOD_GETTABLE) )
   {
     osm_log( p_rcv->p_log, OSM_LOG_ERROR,
              "osm_smir_rcv_process: ERR 2804: "