[openib-general] mthca_multicast_attach/detach questions

[Michael S. Tsirkin]

Hello, Roland!
1. error handling in mthca_multicast_attach looks strange:
   in particular, dont we want to revert the result of
   mthca_alloc if QP is already a member of MGM, or if
   MGM is full?

2. mthca_multicast_detach has an unconditional goto

        if (i != 1)
                goto out;

        goto out;

this looks wrong: it seems you'll never remove an empty multicast group.

Comments?

-- 
MST