[openib-general] Re: [PATCH] add LDFLAGS to perftest/Makefile

[Nishanth Aravamudan]

On 14.12.2005 [15:23:08 -0800], Nishanth Aravamudan wrote:
> On 14.12.2005 [09:14:52 -0800], Grant Grundler wrote:
> > On Wed, Dec 14, 2005 at 01:57:26AM -0800, sagir at openib.org wrote:
> > > Author: sagir
> > > Date: 2005-12-14 01:57:24 -0800 (Wed, 14 Dec 2005)
> > > New Revision: 4453
> > > 
> > > Modified:
> > >    trunk/contrib/mellanox/gen2/src/userspace/perftest/rdma_lat.c
> > 
> > Can someone from mellanox explain why mainline src/userspace
> > is cloned under contrib/mellanox?
> 
> Is there a reason the perftest/Makefile doesn't use LDFLAGS?
> Specifically, in automating userspace build & test, I put the IB
> libraries in a temporary directory, and exporting CFLAGS and LDFLAGS
> works with all other Makefiles (well, the ones I expect to work), but
> perftest does not seem to pick up my exports.
> 
> Would something like the following make sense (sorry if a different -p
> is preferred)? Or does it need to be +=?

It does need to be +=...

Description: Add LDFLAGS to perftest/Makefile to allow non-standard
library location.

Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>

--- Makefile	2005-12-14 14:57:04.000000000 -0800
+++ Makefile.ldflags	2005-12-14 14:57:23.000000000 -0800
@@ -2,6 +2,7 @@ TESTS = rdma_lat rdma_bw
 
 all: ${TESTS}
 
+LDFLAGS +=
 CFLAGS += -Wall -O2 -g -D_GNU_SOURCE 
 LOADLIBES += -libverbs
 EXTRA_FILES = get_clock.c