[openib-general] Re: [PATCH 04/13] [RFC] ipath LLD core, part 1

[Andrew Morton]

Roland Dreier <rolandd at cisco.com> wrote:
>
> +	if ((ret = copy_from_user(&rpkt, p, sizeof rpkt))) {
> +		_IPATH_DBG("Failed to copy in pkt struct (%d)\n", ret);
> +		return ret;
> +	}

The driver does this quite a lot.  copy_from_user() will return the number
of bytes remaining to copy.  So I think we'll be wanting `return -EFAULT;'
in lots of places rather than this.