[openib-general] RE: [PATCH] OpenSM/ib_types.h: Modify ib_port_info_compute_rate

[Eitan Zahavi]

Hi Hal,

Thanks for reverting the patch.

Regarding changing the API, I propose we will discuss every change and
try to limit them to really critical ones. I do not know how we can use
versioning in Header files.

Eitan

Eitan Zahavi
Design Technology Director
Mellanox Technologies LTD
Tel:+972-4-9097208
Fax:+972-4-9593245
P.O. Box 586 Yokneam 20692 ISRAEL


> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Sunday, December 18, 2005 5:48 PM
> To: Eitan Zahavi
> Cc: openib-general at openib.org; Yael Kalka
> Subject: RE: [PATCH] OpenSM/ib_types.h: Modify
ib_port_info_compute_rate
> 
> Hi Eitan,
> 
> On Sun, 2005-12-18 at 06:53, Eitan Zahavi wrote:
> > Hi Hal,
> >
> > The attached patch is fine. Please go ahead and commit it.
> >
> > BTW:
> > In the following commit 4509 you have changed the name of a switch
info
> > record field.
> > Note this is an API change and have severe effect on any application
> > using ib_types.h
> > (and there are plenty of these)
> 
> Is this "API" frozen for all time ? How would you propose that this
> "API" evolve ? I do not see where there is any versioning to the API.
> 
> > I would appreciate if you will revert this un-necessary change.
> 
> I reverted this change.
> 
> > Also in
> > the future please post a patch before changing ib_types.h
> > osm_vendor_api.h osm_vendor_sa_api.h  and any of the complib H
files.
> 
> The previous request on this was for any non cosmetic changes. This
was
> viewed as a cosmetic change (a simple variable name change).I'll now
> post any changes to these header files.
> 
> -- Hal