[openib-general] RE: [PATCH] OpenSM/ib_types.h: Modifyib_port_info_compute_rate

[Fab Tillier]

Hi Hal,

> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Sunday, December 18, 2005 7:48 AM
> 
> On Sun, 2005-12-18 at 06:53, Eitan Zahavi wrote:
> > Hi Hal,
> >
> > The attached patch is fine. Please go ahead and commit it.
> >
> > BTW:
> > In the following commit 4509 you have changed the name of a
> > switch info record field.
> > Note this is an API change and have severe effect on any
> > application using ib_types.h (and there are plenty of these)
> 
> Is this "API" frozen for all time ? How would you propose that this
> "API" evolve ? I do not see where there is any versioning to the API.

The ib_types.h file in the OpenSM project was originally lifted from the IBAL
project.  The Windows OpenIB Project, since it's derived from IBAL, has that
file.  Currently, OpenSM has it's own shadow copy of that header, so changes to
it must be carefully controlled to keep OpenSM building on Windows.

Hopefully that helps explain.

- Fab