[openib-general] Re: [PATCH] osm: support for trivial PKey manager

[Hal Rosenstock]

Hi Ofer,

On Thu, 2005-12-29 at 05:20, Ofer Gigi wrote:
> Hi Hal,
> 
> My name is Ofer Gigi, and I am a new software engineer in Mellanox 
> working on OpenSM.  
> This patch provides a new manager that solves the following problem:

Thanks! I am starting to work on integrating this. 

I have a couple of questions and some comments and questions embedded
below.

How are the PKeys configured ?

Does the SM always go through the extra states to set PKeys ? What if
there are none to be set ?

> OpenSM is not currently compliant to the spec statement:
> C14.62.1.1 Table 183 p870 l34:
> "However, the SM shall ensure that one of the P_KeyTable entries in every
>  node contains either the value 0xFFFF (the default P_Key, full membership) 
>  or the value 0x7FFF (the default P_Key, partial membership)."
> 
> Luckily, all IB devices comes up from reset with preconfigured 0xffff key.
> This was discovered during last plugfest. 

> To overcome this limitation I implemented a simple elementary PKey manager
> that will enforce the above rule (currently adds 0xffff if missing).

Might 0x7fff be better in this case ?

> This additional manager would be used for a full PKey policy manager 
> in the future.

Can you elaborate on any plans in this area as to timing and what "full"
means ?

> We have tested this patch 

Can you elaborate on the testing ?

Thanks again.

-- Hal