[openib-general] Re: [PATCH][SDP] Include asm/ headers *after* linux/ headers

[Libor Michalek]

On Mon, Feb 14, 2005 at 08:23:44AM -0800, Tom Duffy wrote:
> On Fri, 2005-02-11 at 21:58 -0800, Grant Grundler wrote:
> > And sdp_main.h violates one of the kernel include file rules:
> > 	include asm/ headers *after* linux/ headers.
> 
> Include asm/ headers *after* linux/ headers.  This builds for me on x86,
> x86_64, and sparc64.

Thanks, applied and checked in.

-Libor

> Signed-off-by: Tom Duffy <tduffy at sun.com>
> 
> Index: drivers/infiniband/ulp/sdp/sdp_main.h
> ===================================================================
> --- drivers/infiniband/ulp/sdp/sdp_main.h	(revision 1783)
> +++ drivers/infiniband/ulp/sdp/sdp_main.h	(working copy)
> @@ -57,11 +57,6 @@
>  /*
>   * kernel includes
>   */
> -#include <asm/atomic.h>
> -#include <asm/byteorder.h>
> -#include <asm/pgtable.h>
> -#include <asm/io.h>
> -
>  #include <linux/version.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> @@ -85,6 +80,12 @@
>  #include <net/route.h>
>  #include <net/dst.h>
>  #include <net/ip.h>
> +
> +#include <asm/atomic.h>
> +#include <asm/byteorder.h>
> +#include <asm/pgtable.h>
> +#include <asm/io.h>
> +
>  /*
>   * IB includes
>   */
> @@ -107,7 +108,3 @@
>  #include "sdp_buff_p.h"
>  
>  #endif /* _SDP_MAIN_H */
> -
> -
> -
> -