[openib-general] Re: [PATCH][SDP][14/22] Whitespace cleanup in sdp_proto.h

[Michael S. Tsirkin]

Quoting r. Tom Duffy <Tom.Duffy at Sun.COM>:
> Subject: [PATCH][SDP][14/22] Whitespace cleanup in sdp_proto.h
> 
> Signed-off-by: Tom Duffy <tduffy at sun.com>
> 
> Index: linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h
> ===================================================================
> --- linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h	(revision 1836)
> +++ linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h	(working copy)
> @@ -599,14 +599,10 @@ static __inline__ int __sdp_inet_write_s

I think we also should replace __inline__ with inline everywhere.

Also, I think the convention is to add __ before inline functions
if they are an implementation detail and shouldnt be called
directly.
That does not seem to be the case for __sdp_inet_write_space, or for
other stuff in sdp_proto.h, so I think these functions shall have proper names
starting with an alphanumeric.


-- 
MST - Michael S. Tsirkin