[openib-general] Re: [PATCH] OpenSM: Add multicast destination handling into SA PathRecord support

[Hal Rosenstock]

On Mon, 2005-02-21 at 09:23, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > @@ -1153,8 +1160,277 @@
> > [...]
> >
> > +#if 0
> > +  for ( i = 0 ; i < sizeof(p_mgrp->mcmember_rec.mgid.multicast.raw_group_id); i++)
> > +  {
> > +    if (p_mgrp->mcmember_rec.mgid.multicast.raw_group_id[i] !=
> > +        p_recvd_mgid->mgid.multicast.raw_group_id[i])
> > +      return;
> > +  }
> > +#endif
> > +
> 
> I dont claim I know the opensm code well, but is it
> a good idea to add more dead code?

This is just a cut and paste of the same code Eitan had added elsewhere.
Not sure about the origin. I didn't resolve the question:

  /* Why not compare the entire MGID ???? */ 
  /* different scope can sneak in for the same MGID ? */
  /* EZ: I changed it to full compare ! */

I'm not sure how a different scope would "sneak" in. I've been meaning
to ask. If it can't, I'm happy to eliminate the code here and elsewhere
where it appears.

-- Hal